Add CentOS CoreOS (SCOS) & Red Hat Linux CoreOS (RHCOS) by CrAazZyMaN21 · Pull Request #1674 · netbootxyz/netboot.xyz

CrAazZyMaN21 · 2025-09-12T20:39:14Z

Solves #1553

Also adding CentOS CoreOS for the OKD project 😃

antonym · 2025-09-12T23:13:28Z

@claude review

claude · 2025-09-12T23:13:42Z

Claude finished @antonym's task —— View job

Code Review: Add CentOS CoreOS & Red Hat Linux CoreOS

I've reviewed PR #1674 which adds support for CentOS CoreOS and Red Hat Linux CoreOS. Here's my comprehensive analysis:

✅ Positive Aspects

Addresses Valid Need: The PR solves issue [Request] RedHat CoreOS (RHCOS) for OpenShift PXE Boot #1553 and adds support for two important CoreOS variants used in enterprise environments
Follows Existing Patterns: The implementation appears to follow the established pattern used by Fedora CoreOS
Appropriate File Structure: New template files follow the naming convention (centos-coreos.ipxe.j2, rhcos.ipxe.j2)

⚠️ Areas for Review & Potential Issues

1. Configuration Structure Concerns
Based on the existing CoreOS configuration in roles/netbootxyz/defaults/main.yml:191-203, I notice:

The Fedora CoreOS configuration has specific base_dir, mirror, and versioning structure
Need to ensure CentOS CoreOS and RHCOS have appropriate configuration entries with:
- Proper mirror URLs and base directories
- Correct versioning scheme
- Appropriate naming conventions

2. Template File Consistency
From examining the existing coreos.ipxe.j2 template, the new templates should:

Follow the same parameter structure (install_device, ignition_url)
Use consistent variable naming and menu structure
Handle architecture detection properly (x86_64 vs aarch64)
Include proper error handling and exit paths

3. README Integration
The README.md should be updated to include:

CentOS CoreOS entry in the Operating Systems table (around line 138 where Fedora CoreOS is listed)
Red Hat CoreOS entry with appropriate URL references
Consistent formatting with existing entries

4. Missing Configuration Verification
Since I cannot access the actual PR files due to branch access limitations, I recommend verifying:

For main.yml additions:

releases:
  centos-coreos:
    base_dir: [appropriate path]
    enabled: true
    menu: linux
    mirror: [official CentOS CoreOS mirror]
    name: CentOS CoreOS
    versions:
    - code_name: [version]
      name: [display name]
  
  rhcos:
    base_dir: [appropriate path] 
    enabled: true
    menu: linux
    mirror: [official RHCOS mirror]
    name: Red Hat CoreOS
    versions:
    - code_name: [version]
      name: [display name]

For template files:

Ensure URL patterns match official distribution methods
Verify kernel/initrd/rootfs URL structures
Test ignition config integration
Validate install device handling

🔍 Recommendations

Verify Mirror URLs: Ensure the mirror URLs point to official, stable sources
Test Boot Process: Validate that the boot process works with real hardware/VMs
Documentation: Consider adding usage examples or links to official documentation
Versioning Strategy: Ensure the versioning scheme aligns with upstream release patterns

📝 Final Assessment

The PR appears to be a solid addition that follows established patterns. However, without access to the actual implementation details, I recommend:

Manual testing of the boot sequences
Verification of mirror URL stability and availability
Ensuring the configuration aligns with official CoreOS installation methods

Once these items are confirmed, this should be a valuable addition to netboot.xyz's distribution support.

CrAazZyMaN21 · 2025-09-13T00:34:13Z

Hi, I tried to find the issue why the Build PR Pipeline failed but I can't seem to find it. I am guessing the file name "centos-coreos.ipxe.j2" is not suitable and should be changed to e.g "scos.ipxe.j2"

CrAazZyMaN21 · 2025-09-15T22:08:40Z

@antonym Can you please let the workflow run again. I think it is fixed now and I squashed the commits.

CrAazZyMaN21 · 2025-11-09T14:11:10Z

Added RHCOS 4.20
Moved RHCOS 4.18 to Maintenance Support

Copilot

Pull request overview

This PR adds support for two CoreOS variants to netboot.xyz: CentOS Stream CoreOS (SCOS) for the OKD project and Red Hat Enterprise Linux CoreOS (RHCOS) for OpenShift deployments. Both operating systems are designed for container-focused workloads and use the CoreOS installer framework with Ignition configuration.

Key Changes:

Added iPXE boot menu templates for SCOS and RHCOS with support for interactive installation device and Ignition config URL configuration
Added release configurations with version definitions and mirror URLs for both operating systems
Updated README documentation to include both new OS entries in the supported operating systems table

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
roles/netbootxyz/templates/menu/scos.ipxe.j2	New iPXE menu template for CentOS Stream CoreOS with multi-version support and configurable installation parameters
roles/netbootxyz/templates/menu/rhcos.ipxe.j2	New iPXE menu template for Red Hat Enterprise Linux CoreOS with OpenShift version support
roles/netbootxyz/defaults/main.yml	Added configuration entries for both RHCOS (versions 4.12-4.20) and SCOS (versions 9.x and 10.x) with mirror URLs and version metadata
README.md	Added documentation entries for both CoreOS variants in the operating systems compatibility table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-18T07:11:38Z

roles/netbootxyz/templates/menu/scos.ipxe.j2

+
+:install_dev
+echo -n Selected install device will be overwritten,
+echo -n please ensure you know what are you doing...


Grammar issue: "ensure you know what are you doing" should be "ensure you know what you are doing" (remove "are" before "you").

Suggested change

echo -n please ensure you know what are you doing...

echo -n please ensure you know what you are doing...

Copilot · 2025-12-18T07:11:39Z

roles/netbootxyz/templates/menu/rhcos.ipxe.j2

+
+:install_dev
+echo -n Selected install device will be overwritten,
+echo -n please ensure you know what are you doing...


Grammar issue: "ensure you know what are you doing" should be "ensure you know what you are doing" (remove "are" before "you").

Suggested change

echo -n please ensure you know what are you doing...

echo -n please ensure you know what you are doing...

Copilot · 2025-12-18T07:11:39Z

roles/netbootxyz/templates/menu/rhcos.ipxe.j2

+{% for item in releases.rhcos.versions %}
+iseq ${core_version} {{ item.code_name }} ||
+{% endfor %}
+set base_url ${rhcos_mirror}/${os_arch}/dependencies/rhcos


The base_url construction doesn't use the rhcos_base_dir variable that is defined in the configuration (set to "pub/openshift-v4"). The URL path should likely include this base directory. Based on the configuration, consider whether the URL should be ${rhcos_mirror}/${rhcos_base_dir}/${os_arch}/dependencies/rhcos instead of ${rhcos_mirror}/${os_arch}/dependencies/rhcos, or if the base_dir configuration needs to be adjusted to match the actual URL structure.

Suggested change

set base_url ${rhcos_mirror}/${os_arch}/dependencies/rhcos

set base_url ${rhcos_mirror}/${rhcos_base_dir}/${os_arch}/dependencies/rhcos

Copilot · 2025-12-18T07:11:39Z

roles/netbootxyz/templates/menu/rhcos.ipxe.j2

+
+:rhcos_boot
+{% for item in releases.rhcos.versions %}
+iseq ${core_version} {{ item.code_name }} ||


The variable name is incorrect. This line uses ${core_version} but should use ${rhcos_version} to match the variable set on line 23 and used throughout the rest of the file. This will cause the version comparison to fail since core_version is never set in this template.

Suggested change

iseq ${core_version} {{ item.code_name }} ||

iseq ${rhcos_version} {{ item.code_name }} ||

Copilot · 2025-12-18T07:11:39Z

roles/netbootxyz/templates/menu/rhcos.ipxe.j2

+{% for item in releases.rhcos.versions %}
+iseq ${core_version} {{ item.code_name }} ||
+{% endfor %}


This loop appears incomplete. It checks the version but doesn't set any variable or perform any action. Comparing with the scos.ipxe.j2 template (line 32), this should set a variable like set rhcos_major_version {{ item.major_version }} or similar. However, RHCOS versions in the configuration don't have a major_version field, so the logic may need to be different or the loop may not be needed at all.

Suggested change

{% for item in releases.rhcos.versions %}

iseq ${core_version} {{ item.code_name }} ||

{% endfor %}

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-06T03:09:17Z

roles/netbootxyz/defaults/main.yml

+        name: 4.12 [Extended Support]
+      - code_name: 4.14
+        name: 4.14 [Extended Support]
+      - code_name: 4.16
+        name: 4.16 [Maintenance Support]
+      - code_name: 4.17
+        name: 4.17 [Maintenance Support]
+      - code_name: 4.18
+        name: 4.18 [Maintenance Support]
+      - code_name: 4.19
+        name: 4.19 [Full Support]
+      - code_name: 4.20
+        name: 4.20 [Full Support]


The RHCOS version entries are missing the major_version field that is present in the SCOS configuration. While the RHCOS template currently doesn't use major_version in its URL construction (unlike SCOS), the incomplete loop at lines 31-33 in rhcos.ipxe.j2 suggests this field might have been intended. Either add the major_version field to each version entry if it's needed for future URL construction, or remove the useless loop in the template file.

Suggested change

name: 4.12 [Extended Support]

- code_name: 4.14

name: 4.14 [Extended Support]

- code_name: 4.16

name: 4.16 [Maintenance Support]

- code_name: 4.17

name: 4.17 [Maintenance Support]

- code_name: 4.18

name: 4.18 [Maintenance Support]

- code_name: 4.19

name: 4.19 [Full Support]

- code_name: 4.20

name: 4.20 [Full Support]

name: 4.12 [Extended Support]

major_version: 4

- code_name: 4.14

name: 4.14 [Extended Support]

major_version: 4

- code_name: 4.16

name: 4.16 [Maintenance Support]

major_version: 4

- code_name: 4.17

name: 4.17 [Maintenance Support]

major_version: 4

- code_name: 4.18

name: 4.18 [Maintenance Support]

major_version: 4

- code_name: 4.19

name: 4.19 [Full Support]

major_version: 4

- code_name: 4.20

name: 4.20 [Full Support]

major_version: 4

CrAazZyMaN21 force-pushed the development branch 2 times, most recently from 9985e79 to 11ef6a7 Compare September 12, 2025 20:45

CrAazZyMaN21 marked this pull request as draft September 12, 2025 20:52

CrAazZyMaN21 force-pushed the development branch 2 times, most recently from 8ff37bc to 9bac5d2 Compare September 12, 2025 20:59

CrAazZyMaN21 marked this pull request as ready for review September 12, 2025 21:05

CrAazZyMaN21 force-pushed the development branch from 818b4f9 to 10c548f Compare September 15, 2025 22:07

CrAazZyMaN21 changed the title ~~Add CentOS CoreOS & Red Hat Linux CoreOS~~ Add CentOS CoreOS (SCOS) & Red Hat Linux CoreOS (RHCOS) Sep 15, 2025

CrAazZyMaN21 force-pushed the development branch 3 times, most recently from 2130856 to 4da58ab Compare November 9, 2025 14:08

antonym requested a review from Copilot December 18, 2025 07:05

Copilot started reviewing on behalf of antonym December 18, 2025 07:05 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

Add CentOS CoreOS (SCOS) & Red Hat Enterprise Linux CoreOS (RHCOS)

996a201

CrAazZyMaN21 force-pushed the development branch from 4da58ab to 996a201 Compare January 5, 2026 22:16

antonym requested a review from Copilot January 6, 2026 03:05

Copilot started reviewing on behalf of antonym January 6, 2026 03:06 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

	echo -n please ensure you know what are you doing...
	echo -n please ensure you know what you are doing...

	set base_url ${rhcos_mirror}/${os_arch}/dependencies/rhcos
	set base_url ${rhcos_mirror}/${rhcos_base_dir}/${os_arch}/dependencies/rhcos

	iseq ${core_version} {{ item.code_name }} \|\|
	iseq ${rhcos_version} {{ item.code_name }} \|\|

	{% for item in releases.rhcos.versions %}
	iseq ${core_version} {{ item.code_name }} \|\|
	{% endfor %}

Uh oh!

Conversation

CrAazZyMaN21 commented Sep 12, 2025

Uh oh!

antonym commented Sep 12, 2025

Uh oh!

claude bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review: Add CentOS CoreOS & Red Hat Linux CoreOS

✅ Positive Aspects

⚠️ Areas for Review & Potential Issues

🔍 Recommendations

📝 Final Assessment

Uh oh!

CrAazZyMaN21 commented Sep 13, 2025

Uh oh!

CrAazZyMaN21 commented Sep 15, 2025

Uh oh!

CrAazZyMaN21 commented Nov 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

claude bot commented Sep 12, 2025 •

edited

Loading